Project

General

Profile

Bug #1027

alias and mod_compress

Added by Anonymous almost 11 years ago. Updated over 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
mod_compress
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Missing in 1.5.x:

Description

When using an alias, mod_compress dosent create subdirectories for the cached compressed files.

Exmaple

www.domain1.com/my.css

www.domain2.com/n/my.css (n is an alis to domain1.com)

error:
2007-02-12 12:57:03: (mod_compress.c.398) creating cachefile /var/lib/lighttpd/cache/compress//n/themes/obalanet/screen.css-gzip-7964071-2250-1170856112 failed No such file or directory

but /var/lib/lighttpd/cache/compress/ exists.

-- duck

Fix-mod_compress-bug-1027-lighty1.4.patch (3.09 KB) Fix-mod_compress-bug-1027-lighty1.4.patch Tested patch (previous missed symbol "ERROR"), ignore trailing slash now stbuehler, 2008-02-15 15:06
Fix-mod_compress-bug-1027-lighty1.5.patch (7.09 KB) Fix-mod_compress-bug-1027-lighty1.5.patch Ignore trailing slash now + ERROR log style stbuehler, 2008-02-15 15:42
lighttpd-1.4.18-compress-mkdir.patch (2.77 KB) lighttpd-1.4.18-compress-mkdir.patch Optimized version of patch for 1.4.18. spillgroup, 2008-03-07 13:42
lighttpd-1.4.19-compress-mkdir.patch (1.14 KB) lighttpd-1.4.19-compress-mkdir.patch Optimization patch for 1.4.19 spillgroup, 2008-03-12 13:56

Associated revisions

Revision d0862e85 (diff)
Added by stbuehler almost 10 years ago

r2086@chromobil: stefan | 2008-02-26 16:15:28 +0100
Fix #1027: create directories in mod_compress (was broken with alias/userdir)

git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2081 152afb58-edef-0310-8abb-c4023f1b3aa9

History

#1

Updated by darix almost 11 years ago

can you show us the module load order?
the easiest thing might be lighttpd -tp -f /path/to/config 2>&1 | less
and paste the server.modules section from it.

#2

Updated by Anonymous almost 11 years ago

cachefile /var/lib/lighttpd/cache/compress//n/themes/obalanet/screen.css-gzip-7964071-2250-1170856112

isn't there one slash too many after comptess?

-- j3rky

#3

Updated by Anonymous over 10 years ago

I'm having the same problem here. Is there a solution?

My server.modules section:


server.modules = (
    "mod_indexfile",
    "mod_access",
    "mod_alias",
    "mod_accesslog",
    "mod_rewrite",
    "mod_evhost",
    "mod_compress",
    "mod_cgi",
    "mod_fastcgi",
    "mod_dirlisting",
    "mod_staticfile",
    # 11
)

-- ecook

#4

Updated by stbuehler almost 10 years ago

I did not try if the patches are working (I don't use mod_compress), so please report if it works for you.

#5

Updated by stut almost 10 years ago

Was having the same problem here on 1.4.18 - can confirm that the attached patch for 1.4 works.

#6

Updated by Anonymous almost 10 years ago

mkdir_recursive will cause segfault while creating something like "/dir1/" (with trailing slash).


while ((p = strchr(p + 1, '/')) != NULL) {

must be


while ((*p) && (p = strchr(p + 1, '/')) != NULL)) { 
#7

Updated by stbuehler almost 10 years ago

+ Duplicate of #230

#8

Updated by Anonymous almost 10 years ago

please fix! this is a huge annoyance.

#9

Updated by stbuehler almost 10 years ago

Fixed in r2081 for 1.4.x

#10

Updated by spillgroup almost 10 years ago

I've attached a slightly modified version for 1.4.18 which is a bit smarter with mkdir's. The previous behaviour was to try and mkdir every part of a file's patch on every access (even when already in the cache). This patch moves the mkdir's to after the place where it checks for existence.

#11

Updated by stbuehler over 9 years ago

  • Status changed from New to Fixed
  • Resolution set to fixed

Fixed in r2135 for lighty-1.5.x with optimization - i hope it works ;-)

Also available in: Atom