Project

General

Profile

Bug #1081

mod_dirlisting hide-dotfiles contrary to the docs disabled by default

Added by icy almost 11 years ago. Updated almost 2 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
mod_dirlisting
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Missing in 1.5.x:

Description

Hiding of dotfiles is disabled in mod_dirlisting by default but the docs say otherwise.
Disabling it by default could pose a security hole in some situations.

Associated revisions

Revision 3094 (diff)
Added by stbuehler almost 2 years ago

[mod_dirlisting] dir-listing.hide-dotfiles = "enabled" by default (fixes #1081)

From: Stefan Bühler <>

Revision f3606dc5 (diff)
Added by stbuehler almost 2 years ago

[mod_dirlisting] dir-listing.hide-dotfiles = "enabled" by default (fixes #1081)

From: Stefan Bühler <>

git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@3094 152afb58-edef-0310-8abb-c4023f1b3aa9

History

#1

Updated by gstrauss almost 2 years ago

I agree and think that dir-listing.hide-dotfiles = "enable" should be the default.

diff --git a/src/mod_dirlisting.c b/src/mod_dirlisting.c
index 338cb42..0fed2ec 100644
--- a/src/mod_dirlisting.c
+++ b/src/mod_dirlisting.c
@@ -247,7 +247,7 @@ SETDEFAULTS_FUNC(mod_dirlisting_set_defaults) {
                s->excludes = excludes_buffer_init();
                s->dir_listing = 0;
                s->external_css = buffer_init();
-               s->hide_dot_files = 0;
+               s->hide_dot_files = 1;
                s->show_readme = 0;
                s->hide_readme_file = 0;
                s->show_header = 0;
#2

Updated by glen almost 2 years ago

+1 for hiding dot files default

#3

Updated by stbuehler almost 2 years ago

  • Description updated (diff)
  • Assignee deleted (jan)
  • Target version set to 1.4.40
#4

Updated by stbuehler almost 2 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r3094.

Also available in: Atom