Project

General

Profile

Actions

Bug #1213

closed

traffic shaping doesn't work with AIO in lighttpd-1.5.0-r1857

Added by Anonymous almost 17 years ago. Updated almost 16 years ago.

Status:
Fixed
Priority:
Normal
Category:
core
Target version:
ASK QUESTIONS IN Forums:

Description

Traffic shaping (e.g. server.kbytes-per-second = 500) doesn't work with AIO (lighttpd-1.5.0-r1857.tar.gz).
Download stops and timeouts after few kbytes...

-- deblog


Files

lighttpd-150-shaper-bug-wget.txt (1.42 KB) lighttpd-150-shaper-bug-wget.txt Output of test with wget. -- deblog Anonymous, 2007-10-15 23:22
lighttpd-svn-fix-kbps-feature.patch (333 Bytes) lighttpd-svn-fix-kbps-feature.patch Safari, 2008-03-06 02:02
Actions #1

Updated by j0t over 16 years ago

same here but without aio... Download halts after a few seconds and the connection drops..

Actions #2

Updated by Anonymous over 16 years ago

I confirm bug with linux-sendfile backend (without aio and r1992). Lighty simply drops connection (see attachment), perhaps instead of shaping. Probability of connection drop increase with speed of download (e.g. with need of traffic shaping).

-- deblog

Actions #3

Updated by Anonymous over 16 years ago

P.S. Same problem occurs with all network backends (i've tested gthread-aio, gthread-sendfile, write, posix-aio, linux-aio-sendfile, linux-sendfile, writev).

-- deblog

Actions #4

Updated by Anonymous over 16 years ago

I'm genuinely amazed by how incredibly fast are the lighttpd developers at correcting a "major" bug!

Actions #5

Updated by Safari about 16 years ago

Can somebody test that patch?
It seems to give half the configured bw, though.

And why do you use this feature, anyways?
If on Linux, use HTB and SFQ, it actually is good.
Can give priorities over other traffic (DNS, ICMP, etc.), give fair bandwidth to all clients -- per flow or destination IP etc., paces packets evenly (if configured bandwidth reached) instead of just doing
write(stuff)
sleep(one second)

Actions #6

Updated by j0t about 16 years ago

I don't use HTB/SFQ because I need to limit the bandwidth for a single vhost, not for the whole server.

As soon as I get back up and running my testing machine I'll try the patch. Thank you

Actions #7

Updated by stbuehler almost 16 years ago

  • Status changed from New to Fixed
  • Resolution set to duplicate
Actions

Also available in: Atom