Project

General

Profile

Bug #1394

mod_deflate enabled by default

Added by j0t almost 12 years ago. Updated about 3 years ago.

Status:
Obsolete
Priority:
Normal
Assignee:
-
Category:
mod_deflate
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Missing in 1.5.x:
Yes

Description

Please apologize me for my poor english.

I think I've found a bug in lighttpd-1.5.0-svn-r2000. It looks like that when I load mod_deflate, it enables itself by default.

You'll find my lighttpd.conf attached. As you can notice, the host dltst.gotnaruto.com has no explicit 'deflate.enabled = "enabled"' config option, however content from that host is compressed when sent to clients. See this tcp log for details


GET /scans/eng/volume_40/cap372trad.zip HTTP/1.1
Accept: image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/xaml+xml, application/vnd.ms-xpsdocument, application/x-ms-xbap, application/x-ms-application, */*
Accept-Language: en-us
UA-CPU: x86
Accept-Encoding: gzip, deflate
User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; FDM)
Host: dltst.gotnaruto.com
Connection: Keep-Alive

HTTP/1.1 200 OK
Content-Type: application/zip
ETag: "1654962551" 
Accept-Ranges: bytes
Last-Modified: Sat, 29 Sep 2007 17:11:45 GMT
Vary: Accept-Encoding
Content-Encoding: gzip
Transfer-Encoding: chunked
Date: Mon, 01 Oct 2007 15:27:26 GMT
Server: lighttpd/1.5.0

See the following tcp log for the exact same file downloaded from dl.gotnaruto.com which has the exactly same configuration as dltst.gotnaruto.com, except for an explicit 'dir-listing.activate = "disable"' line.


GET /scans/eng/volume_40/cap372trad.zip HTTP/1.1
Accept: image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/xaml+xml, application/vnd.ms-xpsdocument, application/x-ms-xbap, application/x-ms-application, */*
Accept-Language: en-us
UA-CPU: x86
Accept-Encoding: gzip, deflate
User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; FDM)
Host: dl.gotnaruto.com
Connection: Keep-Alive

HTTP/1.1 200 OK
Content-Type: application/zip
ETag: "1654962551" 
Accept-Ranges: bytes
Last-Modified: Sat, 29 Sep 2007 17:11:45 GMT
Content-Length: 2870323
Date: Mon, 01 Oct 2007 15:29:31 GMT
Server: lighttpd/1.5.0

I think this is an undesired behavior because there's no warning in the documentation that loading mod_deflate means enabling it for the whole server automatically, and because mod_deflate could be undesirable for some kinds of web servers (i.e. in the abovementioned examples, lighttpd is serving a 2.8M zip file that needs no compression).
I think that the right behavior should be to explicitly enable mod_deflate. If one wants it for the whole server, he puts the enabling directive in the general portion of the config file, if he wants to enable it on a per-vhost basis, he can do that by explicitly enabling it in each vhost's config.

lighttpd.conf (9.41 KB) lighttpd.conf j0t, 2007-10-01 15:41

Related issues

Related to Feature #1824: Adding mod_deflate to 1.4.xx Fixed2008-11-18

Actions

History

#1

Updated by jrabbit almost 12 years ago

For me, a better solution would be to provide a default mimetypes list for the common mimetypes that compress well rather than a blank list that enables compression of all mimetypes.

This would mean the default settings are usable for the majority of sites and it would then be sensible to default enabled to true.

#2

Updated by gstrauss about 3 years ago

#3

Updated by gstrauss about 3 years ago

  • Description updated (diff)

FYI: https://github.com/lighttpd/lighttpd1.4/pull/67 disables mod_deflate by default in patch for 1.4.x branch

#4

Updated by gstrauss about 3 years ago

  • Assignee deleted (jakabosky)
  • Missing in 1.5.x set to Yes
#5

Updated by gstrauss about 3 years ago

  • Status changed from New to Obsolete

Also available in: Atom