Feature #1737

PATCH: Allow FQDN in mod_evhost path-pattern

Added by Anonymous over 6 years ago. Updated over 5 years ago.

Status:FixedStart date:
Priority:NormalDue date:
Assignee:jan% Done:

100%

Category:mod_evhost
Target version:1.4.23
Missing in 1.5.x:

Description

Hi,

I have a case where I need the FQDN in the "evhost.path-pattern".

There is however a small bug in it, it needs a trailing-slash behind "%_", else the last character in the evhost.path-pattern dosn't make it, I didn't quite understand where this happens.

-- tickets

patch-lighty-mod_evhost-fqdn-pathpattern.sanitize-data.diff Magnifier - -- tickets (1.51 KB) Anonymous, 2008-08-01 12:11

Associated revisions

Revision 2483
Added by stbuehler over 5 years ago

Add '%_' pattern for complete hostname in mod_evhost (fixes #1737)

Revision 2584
Added by stbuehler over 5 years ago

Add '%_' pattern for complete hostname in mod_evhost (fixes #1737)

History

#1 Updated by Anonymous over 6 years ago

According to #lighttpd the trailing slash is expected/resonable behavior.

#2 Updated by Anonymous over 6 years ago

some comments from #lighttpd:

14:57  stbuehler| i don't think we should do that in 1.4.x
14:57        icy| do it for 1.5 only
14:57        icy| or introduce special stuff
14:57  stbuehler| we could rename the options
14:58        icy| %h hostname, %t tld, %d domain
14:58        icy| or something
14:58    Mr_Bond| I agree it's not very nice. Also, if there was a "hostname" variable in the request_uri type, it would be unnessesary to do all the buffer handling
14:58    Mr_Bond| icy, yeah, I like that better
14:58    Mr_Bond| makes more sense
14:58        icy| and %1, %2, %3... to get the n-th part seperated by dots
14:58  stbuehler| i think numbers for the parts are ok
14:58        icy| n-th from the end
14:59        icy| that would make more sense imho
14:59  stbuehler| %0 should just be the fqdn
14:59    Mr_Bond| agree icy, allthough it would break a lot of setups
14:59    Mr_Bond| stbuehler, damn right!
14:59    DarkElf| lol there is also three person did same patch 
14:59  stbuehler| (btw, there is one comment in the source telling %0 is fqdn)
14:59        icy| that's why we should do this to 1.5 only

-- tickets

#3 Updated by Anonymous over 6 years ago

-- tickets

#4 Updated by stbuehler over 6 years ago

The bug with the trailing slash got fixed btw.

#5 Updated by mr_bond almost 6 years ago

  • Target version changed from 1.5.0 to 1.4.21
  • % Done changed from 0 to 100

This is fixed in 1.4.21 with the new mod_evhost :-) This ticket can be closed.

#6 Updated by mr_bond almost 6 years ago

  • % Done changed from 100 to 0

never mind.. just a bogus comment in the source.. it's not fixed..

#7 Updated by stbuehler almost 6 years ago

  • Target version changed from 1.4.21 to 1.4.22
  • Patch available set to No

#8 Updated by stbuehler over 5 years ago

  • Target version changed from 1.4.22 to 1.4.23

#9 Updated by stbuehler over 5 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r2483.

Also available in: Atom