Project

General

Profile

Bug #1757

http_auth.c =>base64_decode

Added by Anonymous almost 8 years ago. Updated over 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
core
Target version:
Start date:
Due date:
% Done:

0%

Missing in 1.5.x:

Description

Hi,

I was looking at http_auth.c, function base64_decode, and found that in the base64_reverse_table there is one row missing, there are 15 rows (16 x 15) instead of 16. I know it's not likely that a character greater or equal 239 appears in the string to be decoded... but I just wanted to say :).

Great webserver! :)

Guido.

-- guido.reina

Associated revisions

Revision 8cfa29a7 (diff)
Added by stbuehler over 7 years ago

Fix base64 decoding in mod_auth (#1757, thx guido)

git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2315 152afb58-edef-0310-8abb-c4023f1b3aa9

Revision 2446 (diff)
Added by stbuehler about 7 years ago

merge: Fix base64 decoding in mod_auth (#1757)

History

#1 Updated by stbuehler almost 8 years ago

  • Status changed from New to Assigned

Yes, you are right. Shouldn't be a real problem, because if the encoded string contains such characters it is broken anyway, but we should ignore the broken characters according to the RFC.

I already have a patch, but i guess i will keep it for after 1.4.20.

#2 Updated by Anonymous almost 8 years ago

I know it wasn't a problem, it is just that it looks strange in the code; things have to be very weird already for trying to convert such characters.

Thank you :),

Guido.

-- guido.reina

#3 Updated by stbuehler over 7 years ago

  • Status changed from Assigned to Fixed
  • Resolution set to fixed

Fixed in r2315

Also available in: Atom