https://redmine.lighttpd.net/https://redmine.lighttpd.net/favicon.ico?13667327412008-11-14T00:33:06Zlighty labsLighttpd - Bug #1821: FD_CLOEXEC not set for log_access_fd and err->fdhttps://redmine.lighttpd.net/issues/1821?journal_id=50772008-11-14T00:33:06ZSafari
<ul></ul><p>Caching highest fd may be hard to implement in a race-free manner...</p>
<p>But would be neat, since closing 4000 fd's needs two milliseconds of CPU time on P4/2.8 GHz / Linux 2.6.27.5.</p> Lighttpd - Bug #1821: FD_CLOEXEC not set for log_access_fd and err->fdhttps://redmine.lighttpd.net/issues/1821?journal_id=51362008-12-07T15:25:08Zstbuehler
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Fixed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset r2363.</p> Lighttpd - Bug #1821: FD_CLOEXEC not set for log_access_fd and err->fdhttps://redmine.lighttpd.net/issues/1821?journal_id=51372008-12-07T15:30:28Zstbuehler
<ul></ul><p>Apart from mod_cgi there should be no performance issues with the "close"-loop. And if you use mod_cgi, you shouldn't care about performance anyway :)</p>
<p>I tried to find all places in which we forgot FD_CLOEXEC - but sometimes it just is not possible (e.g. i have no idea how sqlite works); that is why i don't want to remove the loop completely.<br />But 3..255 should be enough for that cases, as i think they are only used during startup. (finding/caching the highest fd is just impossible)</p>