Lighttpd

There are only two ways I can see this getting done and I'd like an opinion:
1) Pass in con, or con_server_name, to log_error_write
2) Instead of popping con out of srv for the current connection we can declare a connection struct inside of the server struct that would be that current connection

Please let me know your thoughts on this.

How is the "/details.php?id=137679" bit passed? Can't that bit be extended to a full URL?

In your particular error message the con->uri.query is passed in. It can be extended to the full URL by first passing in the con->server_name, however, that would only be for your specific log line as opposed to all helpful places.

stbuehler - I don't understand what you mean w/ your 3rd option. The hostname isn't available in log_error_write unless it is passed in - which would be my first option of passing in con->server_name to log_error_write where needed.

Additionally, this bug was previously marked w/ a target version of 1.4.27 and is now 1.4.x. Are you trying to imply that it's most likely not even worth trying to change b/c it wont get committed to 1.4.x or simply that it's not a priority for 1.4.27?

He means manually including it in the message text itself, like the query.

i don't want to change the api, and i don't like a global state.

In that case, add a second log_error_write function that does take a URL as parameter.

• I don't think it is worth the effort to change/extend the api; and i don't think you need the hostname in every error.
• Yes, this feature has no priority in my eyes. You have a timestamp and url+querystring, that should be good enough to find the matching request in the access.log
• Whether patches get accepted depends on many things... how useful are they, how much time do i need to review/test them, ... 1.4.x doesn't mean we won't accept patches.