Feature #2219

Add version to status page

Added by Olaf-van-der-Spek about 3 years ago. Updated almost 3 years ago.

Status:FixedStart date:2010-06-03
Priority:LowDue date:
Assignee:-% Done:

100%

Category:mod_status
Target version:1.4.27
Missing in 1.5.x:Yes

Description

Could the version be added to the status page?

Merging the status and config pages might be nice too.

status_version-1.5r2728.diff Magnifier (632 Bytes) spaam, 2010-06-03 20:42

status_version-1.4r2728.diff Magnifier (586 Bytes) spaam, 2010-06-03 20:45

Associated revisions

Revision 2744
Added by stbuehler almost 3 years ago

mod_status: Add version to status page (fixes #2219)

  • the status page shouldn't be public anyway, so no reason to hide the version;
    but it makes debugging easier

History

#1 Updated by nitrox about 3 years ago

  • Status changed from New to Wontfix

Merging the pages will not happen, version string might be possible. Patches are welcome.
Wait for upcoming 2.0, it has it all.

#2 Updated by Olaf-van-der-Spek about 3 years ago

  • Status changed from Wontfix to Reopened

version string might be possible.

Then wontfix seems premature...

Wait for upcoming 2.0, it has it all.

How long? ;)

#3 Updated by nitrox about 3 years ago

  • Status changed from Reopened to Need Feedback
  • Priority changed from Normal to Low

We try to get this into status-page.
Merging still as "wontfix".
Lighty 2.0 hopefully before DNF. :)

And you want this for 1.4.28, not 1.4.27?
How comes you can wait that long?

#4 Updated by Olaf-van-der-Spek about 3 years ago

1.4.27 RC has been released already, hence 1.4.28. Sometimes I'm patient. ;)

But seriously, is there any ETA on 2.0?

#5 Updated by nitrox about 3 years ago

http://redmine.lighttpd.net/projects/lighttpd2/wiki
Nope, no release-date yet. Not even plans for alpha/beta or rc´s.

Version-string patch will follow in a few mins. 1.5 is already done. spaam is working hard on this :P

#6 Updated by spaam about 3 years ago

Patch for adding version to 1.5

#7 Updated by spaam about 3 years ago

for 1.4

#8 Updated by nitrox about 3 years ago

  • Status changed from Need Feedback to Patch Pending

#9 Updated by Olaf-van-der-Spek about 3 years ago

  • Target version changed from 1.4.28 to 1.4.27

And you want this for 1.4.28, not 1.4.27?

You win, let's target 1.4.27.

#10 Updated by icy about 3 years ago

I veto those patches. What if you don't want to expose the version? Maybe show server.tag instead.

#11 Updated by Olaf-van-der-Spek about 3 years ago

You're exposing the status page but you don't want to expose the version? That doesn't make much sense.
Use case? :p

#12 Updated by icy about 3 years ago

You could have a static file mirror where you can freely show the status page to anyone interested but still not expose the version.

In lighty 2.0 I introduced a "short" mode for this reason, where it does only show the stats but not connected clients or version and other runtime info.

#13 Updated by Olaf-van-der-Spek about 3 years ago

Then in 2.0, don't show the version in short mode.
In 1.4/1.5, that seems like a privacy violation.

#14 Updated by icy about 3 years ago

True

#15 Updated by Olaf-van-der-Spek about 3 years ago

There's also the case where server.tag is set, but you'd like to see the real version in the status page.

#16 Updated by stbuehler almost 3 years ago

  • Status changed from Patch Pending to Fixed
  • % Done changed from 0 to 100

Applied in changeset r2744.

#17 Updated by icy almost 3 years ago

  • Missing in 1.5.x changed from No to Yes

Also available in: Atom