https://redmine.lighttpd.net/https://redmine.lighttpd.net/favicon.ico?13667327412016-02-13T09:40:23Zlighty labsLighttpd - Bug #2302: sloppy error handling in mod_cgi to affect binarieshttps://redmine.lighttpd.net/issues/2302?journal_id=87622016-02-13T09:40:23Zgstrauss
<ul></ul><p>con->srv_socket is set soon after accept() and so it should never be NULL in mod_cgi. Is this reproducible in 1.4.x latest? Probably not.</p>
<p>I agree that segfaulting after exec failure is not very user friendly.<br />Submitted pull request: <a class="external" href="https://github.com/lighttpd/lighttpd1.4/pull/21">https://github.com/lighttpd/lighttpd1.4/pull/21</a></p> Lighttpd - Bug #2302: sloppy error handling in mod_cgi to affect binarieshttps://redmine.lighttpd.net/issues/2302?journal_id=87822016-02-14T11:08:51Zstbuehler
<ul><li><strong>Target version</strong> set to <i>1.4.40</i></li></ul><p>Ignoring NULL-pointers is not the solution; if there is a good reason in a single case to expect a NULL-pointer, then there needs to be a proper handling of it, and proper handling might be to skip setting the cgi environment variable - but not like this added everywhere without justification.</p>
<p>I'll go with the patch from gstrauss. I don't see a big problem with a SEGFAULT here (because there really is something broken, and it increases the chances the problem shows up in some log), but logging the actual error is better of course.</p> Lighttpd - Bug #2302: sloppy error handling in mod_cgi to affect binarieshttps://redmine.lighttpd.net/issues/2302?journal_id=87842016-02-14T11:15:05Zstbuehler
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Fixed</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li></ul><p>Applied in changeset r3079.</p>