Project

General

Profile

Bug #2381

mod_accesslog %U format field regression

Added by presbrey almost 6 years ago. Updated almost 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2012-01-10
Due date:
% Done:

0%

Estimated time:

Description

lighty 1.x, %U = con->uri.path_raw ~ preserved after alias, rewrite, ...

https://github.com/lighttpd/lighttpd1.4/blob/lighttpd-1.5.x/src/mod_accesslog.c#L848

            case FORMAT_URL:
                accesslog_append_escaped(b, con->uri.path_raw);
                break;

lighty 2, %U = req->uri.path ~ overwritten by rewrite action and maybe others

https://github.com/lighttpd/lighttpd2/blob/master/src/modules/mod_accesslog.c#L338

            case AL_FORMAT_PATH:
                g_string_append_len(str, GSTR_LEN(req->uri.path));
                break;

Its now impossible to get the original request path (without query) except for using entire first line (%r).

History

#1

Updated by stbuehler almost 6 years ago

there will be many differences between 1.x and 2.0, so i wouldn't call this a regression.

whether we want to support more of the apache style log format (">", "<", status code conditionals, ...) is a different topic.

#2

Updated by presbrey almost 6 years ago

Differences are ok, but original request path is lost by rewrite. Anyone upgrading to 2 from 1.x will call this a regression. Perhaps newcomers will not notice :)

Also available in: Atom