Bug #2435

[mod_proxy] test failures leave running processes

Added by KiBi over 1 year ago. Updated over 1 year ago.

Status:FixedStart date:2012-08-14
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:test_component
Target version:1.4.32
Missing in 1.5.x:No

Description

Hi,

while improving my patch for #2434, I've made my initially-patched tests go wrong by passing empty substrings in the proxy.forward-env-vars config variable (due to prev+1 in strchr()). Unfortunately, the real server doesn't go away when the proxy server is killed, so subsequent tests all fail, and one has to run “killall lighttpd” to get rid of the running process.

The attached patch kills real+proxy instances explicitly, to make sure everyone goes away, no matter what the failure mode is.

Mraw,
KiBi

Associated revisions

Revision 2857
Added by stbuehler over 1 year ago

tests: make sure mod_proxy doesn't leave running processes (fixes #2435, thx kibi)

In case the proxy instance goes wrong, the clean-up doesn't kill the
real instance. So close both instances explicitly in the clean-up
phase.

Signed-off-by: Cyril Brulebois <>

History

#1 Updated by stbuehler over 1 year ago

  • Target version changed from 1.4.x to 1.4.32

#2 Updated by stbuehler over 1 year ago

  • Status changed from Patch Pending to Fixed
  • % Done changed from 0 to 100

Applied in changeset r2857.

Also available in: Atom