https://redmine.lighttpd.net/https://redmine.lighttpd.net/favicon.ico?13667327412016-02-27T23:48:16Zlighty labsLighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=89362016-02-27T23:48:16Zgstrauss
<ul></ul><p>Read through patch and it looks sane to me.</p>
<p><a class="user active user-mention" href="https://redmine.lighttpd.net/users/9903">@ef</a>, would you consider writing a few tests in tests/*.t to validate the patch? Thanks.</p> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=89452016-02-28T11:48:09Zstbuehler
<ul><li><strong>Target version</strong> set to <i>1.4.x</i></li></ul> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=89472016-02-28T11:49:13Zstbuehler
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-6 priority-4 priority-default closed" href="/issues/385">Bug #385</a>: Enabling ipv6 makes matching subnets with $HTTP["remoteip"] inoperable.</i> added</li></ul> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=91282016-03-17T12:51:36Zgstrauss
<ul></ul><p><a class="user active user-mention" href="https://redmine.lighttpd.net/users/9903">@ef</a>: would you consider writing a few tests in tests/*.t to validate the patch? Thanks.</p> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=91622016-03-22T10:28:40Zef
<ul></ul><p>gstrauss wrote:</p>
<blockquote>
<p>would you consider writing a few tests in tests/*.t to validate the patch?</p>
</blockquote>
<p>I may <em>consider</em> that, but I'm neither familiar with lighttpd's test framework nor will I have time left to do that anytime soon, sorry.</p> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=91652016-03-22T12:14:40Zgstrauss
<ul><li><strong>Tracker</strong> changed from <i>Bug</i> to <i>Feature</i></li></ul><blockquote>
<p>The attached patch lacks MS-Windows support.</p>
</blockquote>
<p>Would you provide a link or two, or a quick explanation why? Thx.</p> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=91662016-03-22T12:39:49Zef
<ul></ul><p>gstrauss wrote:</p>
<blockquote>
<p>Would you provide a link or two</p>
</blockquote>
<p>I don't understand. A link to what?</p>
<blockquote>
<p>or a quick explanation why?</p>
</blockquote>
<p>Because I don't know how to write that support.<br />There's an <code>#ifdef __WIN32</code> in the code and the true branch uses some <code>inet_addr()</code> function (while the false branch used <code>inet_aton()</code> and now uses <code>inet_pton()</code>).<br />I have no idea how to parse (nor any chance to test) network addresses on MS-Windows.</p> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=91672016-03-22T13:06:00Zgstrauss
<ul></ul><p>Windows provides inet_pton() in versions of Windows <em>after</em> Windows XP, so that patch needs to be adjusted for that. I don't think we should worry about supporting Windows XP or earlier.</p> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=91682016-03-22T13:12:17Zef
<ul></ul><p>gstrauss wrote:</p>
<blockquote>
<p>so that patch needs to be adjusted for that.</p>
</blockquote>
<p>By someone with access to an MS-Windows machine, probably.</p> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=92962016-04-04T05:33:45Zgstrauss
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Patch Pending</i></li><li><strong>Target version</strong> changed from <i>1.4.x</i> to <i>1.4.40</i></li></ul><p>Submitted pull request <a class="external" href="https://github.com/lighttpd/lighttpd1.4/pull/52">https://github.com/lighttpd/lighttpd1.4/pull/52</a></p> Lighttpd - Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"]https://redmine.lighttpd.net/issues/2706?journal_id=94622016-04-25T06:00:18Zgstrauss
<ul><li><strong>Status</strong> changed from <i>Patch Pending</i> to <i>Fixed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[core] support IPv6 in $HTTP["remote-ip"] CIDR cond match (fixes #2706) x-ref: "Matching IPv6 ..." href="https://redmine.lighttpd.net/projects/lighttpd/repository/14/revisions/bed63b79625cf98f41317b62519fa8abb7a82c1e">bed63b79625cf98f41317b62519fa8abb7a82c1e</a>.</p>