Bug #1235

NULL arg terminator in execl()/execle() is missing

Added by Anonymous about 3 years ago. Updated about 2 years ago.

Status:Fixed Start:
Priority:Normal Due date:
Assigned to:- % Done:

0%
Category:core
Target version:1.5.0
Missing in 1.5.x:

Description

Some systems define NULL as a (void *) pointer, other systems just define it as 0.

On functions having a fixed number of arguments, this is not an issue. Thanks to the prototype, the NULL will be promoted to the right type to close the argument list.

But on functions with a variable number of arguments, if an integer object is used where a pointer is expected, bad things can happen. This is for instance the case on OpenBSD/amd64.

Here's a patch that fixes the execl()/execle() calls in Lighty 1.5 -SVN.

fix-sentinel.patch - Fix for NULL-terminated argument lists -- Frank DENIS (2 KB) Anonymous, 06/14/2007 08:45 am

Associated revisions

Revision 1872
Added by jan about 3 years ago

fixed type-cast for NULL in execl() (fixes #1235), fix provided by Frank
DENIS

Revision 1916
Added by jan about 3 years ago

added a sentinel around NULL in exec() (merged from [1872] from 1.4.x,
fixes #1235)

History

Updated by jan about 3 years ago

  • Status changed from New to Fixed
  • Resolution set to fixed

fixed in r1916 for trunk and r1872 for 1.4.x

Updated by Anonymous about 2 years ago

  • Status changed from Fixed to Need Feedback
  • Resolution deleted (fixed)

Updated by glen about 2 years ago

  • Status changed from Need Feedback to Fixed
  • Resolution set to fixed

Also available in: Atom