Bug #1436
when server.max-connections is hit cpu load dramatically increases
| Status: | Fixed | Start: | ||
| Priority: | Urgent | Due date: | ||
| Assigned to: | stbuehler | % Done: | 100% |
|
| Category: | core | |||
| Target version: | 1.4.21 | |||
Description
it seems that as soon as server.max-connections is hit lighttpd becomes very busy turning new connections away, easily jumping to 100% cpu load.
this is on linux, observed with several machines
-- w1zzard
Related issues
| duplicated by Bug #577 | lighttpd terminally ceases serving connections when server.max-connections state reached | Fixed |
Associated revisions
Fix max-connection limit handling/100% cpu usage (fixes #1436)
merge: Fix max-connection limit handling/100% cpu usage (#1436)
History
Updated by manik 7 months ago
Anonymous wrote:
it seems that as soon as server.max-connections is hit lighttpd becomes very busy turning new connections away, easily jumping to 100% cpu load.
this is on linux, observed with several machines
-- w1zzard
this seems to be an artifact of the following code in network.c
/* accept()s at most 100 connections directly
*
* we jump out after 100 to give the waiting connections a chance */
for (loops = 0; loops < 100 && NULL != (con = connection_accept(srv, srv_socket)); loops++) {
handler_t r;connection_state_machine(srv, con);in connection_accept, a check is made if the number of server connections have been exceeded.
perhaps a fix here would be to avoid going into that loop at all when
srv->conns->used >= srv->max_conns.