[1.5] PATCH: allow server.error-handler-504

Hi all,

this generates a redirect (via Location: ...) for error 504 (protocol timeout in mod_proxy_core).

Cheers Alex

lighttpd-1.5.x-error-handler-504.diff (21 KB) lighttpd-1.5.x-error-handler-504.diff

Replies (4)

RE: PATCH: allow server.error-handler-504 - Added by stbuehler over 14 years ago

I don't recommend handling timeouts of "dynamic" backends with a dynamic backend. (in other words: this patch will not go upstream).

RE: PATCH: allow server.error-handler-504 - Added by darix over 14 years ago

ugh. your patch modifies the return code.
as stbuehler already said. handling error conditions in dynamic content is not going to work properly.
if you want a custom error page use server.errorfile-prefix.

RE: PATCH: allow server.error-handler-504 - Added by e-razor over 14 years ago

Yeah, we've had a more or less rational discussion about this at the IRC channel.

I agree about the problem with some kind of loops cos of a bad configuration. (occurs when the server.error-handler-504 causes a 504 too)

Sad thing is, that server.errorfile-prefix does not allow any kind of query string for special pages.

My setup for example contains something like this:

$HTTP["url"] !~ "lib/exe/" {
        server.error-handler-504 = "/c2k-tng/remote:state/?dev="+var.vertex_host+"&base_path=/"+var.vertex_path+"/" 
}

Which works very nice for me.

Anyway, it's your decission and I'll not going to argue.

BTW, I'm pretty sure http://redmine.lighttpd.net/boards/3/topics/1650 is still required for server.errorfile-prefix.

Cheers Alex

RE: PATCH: allow server.error-handler-504 - Added by stbuehler over 14 years ago

Yes, i saw it and i think it is probably a good patch. Could you please file it as a bug?

(1-4/4)

Project

General

Profile

Lighttpd