https://redmine.lighttpd.net/https://redmine.lighttpd.net/favicon.ico?13667327412009-03-07T13:53:48Zlighty labsLighttpd - Bug #1923: Compilation on AIXhttps://redmine.lighttpd.net/issues/1923?journal_id=56312009-03-07T13:53:48Zstbuehler
<ul></ul><ul>
<li>Please use "diff -u" for creating diffs</li>
<li>mmap problem:</li>
</ul>
<blockquote>
<p>It might be cleaner to not use a runtime function as a struct member? I can dig deeper to see the conflict...</p>
</blockquote>
<p>This is something i don't like. Sure, we could rename mmap to "my_mmap" or something else. But how can we be sure there will be no <code>#define my_mmap my_mmap64</code>?<br />Imho no platform should use such defines (even <code>#define mmap(param, list) mmap64(param, list)</code> isn't safe); using static inline functions should be the right thing.</p>
But i think we can fix this if we add <code>#include "sys-mmap.h"</code> in chunk.h after line 5 ("array.h"); it would be nice if you could test this.
<ul>
<li>The other problems should be fixed in the next commit.</li>
</ul>
<p>Thx!</p> Lighttpd - Bug #1923: Compilation on AIXhttps://redmine.lighttpd.net/issues/1923?journal_id=56322009-03-07T13:58:29Zstbuehler
<ul><li><strong>Target version</strong> set to <i>1.4.23</i></li></ul> Lighttpd - Bug #1923: Compilation on AIXhttps://redmine.lighttpd.net/issues/1923?journal_id=56402009-03-07T17:33:59Zcstup
<ul></ul><p>Sorry about the diff issue. I was just kinda throwing it together and wasn't paying attention to old/new either. I'll make sure to be more consistant (and use diff -u) next time. The -u option is a GNU diff thing which AIX doesn't support by default, so I usually forget.</p>
<p>I'm not sure how I feel about the mmap() thing either. I agree with you that its goofy the system has a #define based remapping (no pun intended) of the symbol, but OTOH it might also be considered poor form to use a function name as a struct member. At best, it was a bit confusing to see mmap as a nested struct member to the uninitiated.</p>
<p>A crappy compile time hack might be something like:<br /><pre>
#if defined(_AIX) && defined(mmap)
#error compile time assertion, mmap has been redefined
#endif
</pre></p>
<p>At least that would point it out on future AIX builds...</p>
<p>I'll be happy to test the chunk.h change shortly. I'll report my findings.</p>
<p>Thanks!</p> Lighttpd - Bug #1923: Compilation on AIXhttps://redmine.lighttpd.net/issues/1923?journal_id=57902009-04-09T15:57:05Zstbuehler
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Missing Feedback</i></li></ul> Lighttpd - Bug #1923: Compilation on AIXhttps://redmine.lighttpd.net/issues/1923?journal_id=57942009-04-09T17:24:39Zcstup
<ul></ul><p>Sorry for not updating the ticket. The change adding sys-mmap.h chunk.h fixes the issue, as expected. As long as the same redefines occur consistantly, we're okay.</p>
<p><code>chunk.h:<br />#include "buffer.h" <br />#include "array.h" <br />#include "sys-mmap.h"</code></p>
<p>Thanks!</p> Lighttpd - Bug #1923: Compilation on AIXhttps://redmine.lighttpd.net/issues/1923?journal_id=109232017-02-28T04:50:59Zgstrauss
<ul><li><strong>Category</strong> set to <i>core</i></li><li><strong>Status</strong> changed from <i>Missing Feedback</i> to <i>Fixed</i></li></ul>