https://redmine.lighttpd.net/https://redmine.lighttpd.net/favicon.ico?13667327412019-03-12T14:29:20Zlighty labsLighttpd - Bug #2941: failed assertion on incoming bad request when server.error-handler option is usedhttps://redmine.lighttpd.net/issues/2941?journal_id=117092019-03-12T14:29:20Zgstrauss
<ul></ul><p>Thanks for the patch. I think this is more generic and more correct for a wider variety of clients.</p>
<pre>
--- a/src/connections.c
+++ b/src/connections.c
@@ -1192,6 +1192,7 @@ static int connection_handle_request(server *srv, connection *con) {
} else { /*(preserve behavior for server.error-handler-404)*/
con->error_handler_saved_status = -con->http_status; /*(negative to flag old behavior)*/
}
+ if (con->request.http_version == HTTP_VERSION_UNSET) con->request.http_version = HTTP_VERSION_1_0;
buffer_copy_buffer(con->request.uri, error_handler);
connection_handle_errdoc_init(con);
</pre> Lighttpd - Bug #2941: failed assertion on incoming bad request when server.error-handler option is usedhttps://redmine.lighttpd.net/issues/2941?journal_id=117102019-03-12T14:55:49Zandpr
<ul></ul><p>Sure, you're the expert. Your patch works for me too.<br />Thanks for the fast feedback.</p> Lighttpd - Bug #2941: failed assertion on incoming bad request when server.error-handler option is usedhttps://redmine.lighttpd.net/issues/2941?journal_id=117122019-03-13T04:49:02Zgstrauss
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Patch Pending</i></li><li><strong>Target version</strong> changed from <i>1.4.x</i> to <i>1.4.54</i></li></ul> Lighttpd - Bug #2941: failed assertion on incoming bad request when server.error-handler option is usedhttps://redmine.lighttpd.net/issues/2941?journal_id=117142019-03-13T06:35:08Zgstrauss
<ul><li><strong>Status</strong> changed from <i>Patch Pending</i> to <i>Fixed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[core] fix assertion with server.error-handler (fixes #2941) (thx andpr) x-ref: "failed asser..." href="https://redmine.lighttpd.net/projects/lighttpd/repository/14/revisions/5440f04e8a9476e9a8665a93db3934a566f8beec">5440f04e8a9476e9a8665a93db3934a566f8beec</a>.</p>