Project

General

Profile

Actions

Bug #1008

closed

make Fails with webdav-locks

Added by mars over 18 years ago. Updated about 18 years ago.

Status:
Fixed
Priority:
Normal
Category:
mod_webdav
Target version:
-
ASK QUESTIONS IN Forums:

Description

When building on Linux x86_64 (CentOS 4.2) with --webdav-locks, the following error occurs, stopping make:


 gcc -DHAVE_CONFIG_H -DLIBRARY_DIR=\"/usr/local/lib\" -I. -I. -I.. -D_REENTRANT -D__EXTENSIONS__ -DOPENSSL_NO_KRB5 -I/usr/include/pcre -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGE_FILES -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -g -O2 -Wall -W -Wshadow -pedantic -std=gnu99 -MT mod_webdav_la-mod_webdav.lo -MD -MP -MF .deps/mod_webdav_la-mod_webdav.Tpo -c mod_webdav.c  -fPIC -DPIC -o .libs/mod_webdav_la-mod_webdav.o
mod_webdav.c: In function `webdav_has_lock':
mod_webdav.c:1179: error: too few arguments to function `array_get_element'
mod_webdav.c: In function `mod_webdav_subrequest_handler':
mod_webdav.c:2200: error: too few arguments to function `array_get_element'
mod_webdav.c:2364: error: too few arguments to function `array_get_element'
mod_webdav.c:2407: error: too few arguments to function `array_get_element'
make[2]: *** [mod_webdav_la-mod_webdav.lo] Error 1
make[2]: Leaving directory `/home/mars/build/lighttpd-1.5.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/mars/build/lighttpd-1.5.0'
make: *** [all] Error 2
Actions #1

Updated by Anonymous over 18 years ago

Same happend on Linux PPC (Gentoo)

Actions #2

Updated by Anonymous over 18 years ago

seems like a change in array.c which didn't get cleaned up.
i got it to compile after switching back the function call to the original

from
array_get_element(con->request.headers, "If")

to
array_get_element(con->request.headers, "If", strlen("If")

quite a number of similar function call in the code.

-- chengann

Actions #3

Updated by Anonymous about 18 years ago

There is a macro that is supposed to take care of that for you: CONST_STR_LEN.

perl -i.bak -pe 'next unless /array_get_element/; s/".*?"/CONST_STR_LEN($&)/ unless /CONST_STR_LEN/' src/mod_webdav.c

might help.

-- adb

Actions #4

Updated by jan about 18 years ago

  • Status changed from New to Fixed
  • Resolution set to fixed

fixed in r1773

Actions

Also available in: Atom