Project

General

Profile

Bug #1023

HAVE_INET_NTOP doesn't imply HAVE_IPV6 on Cygwin (src/sys-socket.h)

Added by eb over 12 years ago. Updated about 3 years ago.

Status:
Obsolete
Priority:
Normal
Assignee:
-
Category:
core
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Missing in 1.5.x:
Yes

Description

In SVN trunk revision 1629, src/sys-socket.h causes HAVE_IPV6 to be defined if HAVE_INET_NTOP is defined. This is not correct on Cygwin, causing compilation errors in several files. The following patch fixes those compiler errors, but I do not know if the resulting behavior is correct:

Index: src/sys-socket.h ===================================================================
--- src/sys-socket.h (revision 1629)
+++ src/sys-socket.h (working copy)
@ -45,11 +45,13 @
#endif /* !_WIN32 */

#ifdef HAVE_INET_NTOP
#ifndef CYGWIN
/* only define it if it isn't defined yet */
#ifndef HAVE_IPV6
#define HAVE_IPV6
#endif
#endif
#endif
typedef union {
#ifdef HAVE_IPV6

History

#1

Updated by eb over 12 years ago

Sorry, the Version for this should be 1.5.x-svn

#2

Updated by gstrauss over 3 years ago

  • Description updated (diff)
  • Target version set to 1.5.0
#3

Updated by gstrauss about 3 years ago

  • Assignee deleted (jan)
  • Missing in 1.5.x set to Yes
#4

Updated by gstrauss about 3 years ago

  • Status changed from New to Obsolete

Also available in: Atom