Project

General

Profile

Bug #1082

mod_sql_vhost_core bug renders plugin useless

Added by icy over 12 years ago. Updated over 12 years ago.

Status:
Fixed
Priority:
High
Assignee:
-
Category:
mod_mysql_vhost
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Missing in 1.5.x:

Description

Line 182 in mod_sql_vhost_core: the if statement will ALWAYS be true because mod_mysql_vhost_get_vhost() always returns HANDLER_GO_ON (which is not 0) and therefor disabled the whole plugin.

Changing the returnvalue in line 271 in mod_mysql_vhost.c from HANDLER_GO_ON to 0 will fix this issue.
Or one could change all but the last return value in mysql_vhost_get_vhost to HANDLER_ERROR and in the mentioned if statement in mod_sql_vhost_core the 0 to HANDLER_GO_ON or to if (HANDLER_ERROR == ..)

History

#1

Updated by jan over 12 years ago

  • Status changed from New to Fixed
  • Resolution set to fixed

this should be fixed in r1746

Also available in: Atom