Actions
Bug #1295
closedlighttpd runs in endless loop on FreeBSD if a file was shrinked.
ASK QUESTIONS IN Forums:
Description
There are serveral programming errors in http://trac.lighttpd.net/trac/browser/branches/lighttpd-1.4.x/src/network_freebsd_sendfile.c
First, in line 152 is an off-by-one:
if (offset > sce->st.st_size) {
log_error_write(srv, FILE_, LINE_, "sb", "file was shrinked:", c->file.name);
return -1;
}
it should be
offset >= sce->st.st_size
because it does not make sense to open a file and read data past end of file.
This is harmless, sendfile(2) can handle this case:
The offset argument specifies where to begin in the file. Should offset
fall beyond the end of file, the system will return success and report 0
bytes sent as described below.
but lighttpd does not check for 0 bytes sent (line 181-187). Now lighttpd runs open/sendfile/close in an endless loop, read & send 0 bytes.
For a fix, see the linux sendfile implementation at src/network_linux_sendfile.c line 177.
Updated by darix over 17 years ago
- Status changed from New to Fixed
- Resolution set to duplicate
duplicate of #1289
Actions
Also available in: Atom