Project

General

Profile

Bug #1365

Comfusing code in fdevent_linux_sysepoll_get_revents

Added by gladandong almost 12 years ago. Updated almost 11 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
core
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Missing in 1.5.x:

Description

I am new to lighty, these days I am reading the source code of /trunk.

The following code made me comfused:

http://trac.lighttpd.net/trac/browser/trunk/src/fdevent_linux_sysepoll.c#L86

should this line:


fdevent_revents_add(revents, ev->epoll_events[ndx].data.fd, e);

be changed to:


fdevent_revents_add(revents, ev->epoll_events[ndx].data.fd, events);

Associated revisions

Revision 2343 (diff)
Added by stbuehler almost 11 years ago

Use "converted" event flags (fixes #1365)

History

#1

Updated by stbuehler almost 11 years ago

  • Status changed from New to Assigned
  • Assignee changed from jan to stbuehler
  • Patch available set to No
#2

Updated by stbuehler almost 11 years ago

  • Pending changed from Yes to No
  • Patch available changed from No to Yes
#3

Updated by stbuehler almost 11 years ago

  • Patch available changed from Yes to No

You are right; it just works as the constants have the same value.

#4

Updated by stbuehler almost 11 years ago

  • Status changed from Assigned to Fixed
  • % Done changed from 0 to 100

Applied in changeset r2343.

Also available in: Atom