Project

General

Profile

Actions
Copy link

Bug #1757

closed

http_auth.c =>base64_decode

Added by Anonymous over 16 years ago. Updated about 16 years ago.

Status:
Fixed
Priority:
Normal
Category:
core
Target version:
1.4.21
ASK QUESTIONS IN Forums:

Description

Hi,

I was looking at http_auth.c, function base64_decode, and found that in the base64_reverse_table there is one row missing, there are 15 rows (16 x 15) instead of 16. I know it's not likely that a character greater or equal 239 appears in the string to be decoded... but I just wanted to say :).

Great webserver! :)

Guido.

-- guido.reina

Actions
Copy link
 #1

Updated by stbuehler over 16 years ago

  • Status changed from New to Assigned

Yes, you are right. Shouldn't be a real problem, because if the encoded string contains such characters it is broken anyway, but we should ignore the broken characters according to the RFC.

I already have a patch, but i guess i will keep it for after 1.4.20.

Actions
Copy link
 #2

Updated by Anonymous over 16 years ago

I know it wasn't a problem, it is just that it looks strange in the code; things have to be very weird already for trying to convert such characters.

Thank you :),

Guido.

-- guido.reina

Actions
Copy link
 #3

Updated by stbuehler about 16 years ago

  • Status changed from Assigned to Fixed
  • Resolution set to fixed

Fixed in r2315

Actions
Copy link

Also available in: Atom