Project

General

Profile

Actions
Copy link

Bug #2068

closed

mod_expire adding Cache-Control header

Added by glen about 15 years ago. Updated over 13 years ago.

Status:
Fixed
Priority:
Normal
Category:
mod_expire
Target version:
1.4.24
ASK QUESTIONS IN Forums:

Description

seems if mod_env combined with mod_expires to have such headers breaks:

    expire.url = (
        "/" => "access plus 5 weeks",
    )

    setenv.add-response-header += (
        "Cache-Control" => "public" 
    )

Cache-Control: public
Cache-Control: max-age=3024000

while the expected result is:

Cache-Control: public, max-age=3024000

Files

Download all files
expire2.patch (2.15 KB) expire2.patch patch. tested. works glen, 2009-09-18 12:40
expire-1.5.patch (2.19 KB) expire-1.5.patch patch for 1.5 glen, 2010-01-21 08:48
expire-1.5b.patch (2.19 KB) expire-1.5b.patch bugx glen, 2010-01-22 14:25
Actions
Copy link
 #1

Updated by glen about 15 years ago

proposed patch. tested works:

  Cache-Control: public, max-age=3024000
Actions
Copy link
 #2

Updated by glen about 15 years ago

  • % Done changed from 0 to 90
Actions
Copy link
 #3

Updated by glen about 15 years ago

  • Status changed from New to Fixed
  • % Done changed from 90 to 100

Applied in changeset r2621.

Actions
Copy link
 #4

Updated by pioklo almost 15 years ago

Hello !

Its possible to append this patch into 1.5.x ?

regards,
Piotr

Actions
Copy link
 #5

Updated by glen almost 15 years ago

patch against r2704, please test and report back!

Actions
Copy link
 #6

Updated by pioklo almost 15 years ago

if (NULL != (ds = (data_string *)array_get_element(con->response.headers, key))) {

should be

if (NULL != (ds = (data_string *)array_get_element(con->response.headers, key,keylen ))) {

I have have tested this patch and my few servers working fine

Regards,
Piotr Kloc

Actions
Copy link
 #8

Updated by demimurych over 13 years ago

File expire-1.5b.patch have error
in line
if (NULL != (ds = (data_string *)array_get_element(con->response.headers, key, leylen))) {

should be
if (NULL != (ds = (data_string *)array_get_element(con->response.headers, key, keylen))) {

leylen => keylen

Actions
Copy link

Also available in: Atom