Project

General

Profile

Actions

Bug #214

closed

configure.in fixes

Added by Anonymous over 16 years ago. Updated over 14 years ago.

Status:
Fixed
Priority:
Normal
Category:
core
Target version:
-
ASK QUESTIONS IN Forums:

Description

The attached patch fixes three things:


 - the logic of all the optional features (AC_ARG_WITH stuff)
 - FAM_LIB should be FAM_LIBS (pkg-config sets VAR_LIBS and VAR_CFLAGS).
    Also the AC_SUBST is unnecessary as PKG_CHECK_MODULES automatically
   calls AC_SUBST for VAR_LIBS and VAR_CFLAGS iirc.
 - typos in the (en|dis)able_features stuff.  Both gdbm and memcache
   conditonionals set enable_features even if disabled, thus they show up
   as enabled even when they're not.

The first item required a little more explanation as to why the current logic
is flawed. The current logic assumes that if --with-OPTION is specified
that it should be enabled. This goes out the window as soon as a user
specifies --without-OPTION (which autoconf interprets as --with-OPTION=no).
As I explained on irc, this breaks build systems that automatically pass
--with-OPTION or --without-OPTION based on whether the OPTION flag is set
(gentoo calls them USE flags).

-- ka0ttic


Files

lighttpd-1.4.0-fix-configure.diff (5.96 KB) lighttpd-1.4.0-fix-configure.diff lighttpd-1.4.0-fix-configure.diff -- ka0ttic Anonymous, 2005-08-21 11:35
lighttpd-merge-1.4.x-fix-without-webdav.diff (873 Bytes) lighttpd-merge-1.4.x-fix-without-webdav.diff -- Aaron Walker <ka0ttic Anonymous, 2005-08-22 12:05
Actions #1

Updated by jan over 16 years ago

  • Status changed from New to Assigned
Actions #2

Updated by jan over 16 years ago

  • Status changed from Assigned to Fixed
  • Resolution set to fixed

merged into changeset r599

Actions #3

Updated by Anonymous over 16 years ago

sorry didn't realize you already fixed --without-webdav-props.

-- Aaron Walker <ka0ttic

Actions

Also available in: Atom