Project

General

Profile

Actions

Feature #2148

closed

no mod_accesslog timezone support on Solaris

Added by gadams over 15 years ago. Updated about 9 years ago.

Status:
Missing Feedback
Priority:
Normal
Category:
mod_accesslog
Target version:
-
ASK QUESTIONS IN Forums:

Description

Solaris doesnt have tm_gmtoff in its struct tm, so mod_accesslog always uses +0000. It appears to get the time right, but it would be nice to support the local timezone on Solaris, as on other modern OSes.

I have written and tested some code to make this work, complete with autoconf support to determine when to compile it in.

One last thing I noticed is that on machines with no localtime_r but with tm_gmtoff, struct tm will not be initialized. I don't know if such machines exist, but my patch addresses this, as well (causing a compilation error rather than a runtime miscalculation).


Files

solaris-timezone.patch (1.99 KB) solaris-timezone.patch gadams, 2010-01-08 20:16
Actions #1

Updated by gadams over 15 years ago

I should note that my patch is against the trunk, as of r2700.

Actions #2

Updated by gadams over 15 years ago

  • Status changed from New to Patch Pending
Actions #3

Updated by gstrauss about 9 years ago

Do you recall on which versions of Solaris this was needed? Is it still needed on Solaris 10 or Solaris 11?

Actions #4

Updated by gstrauss about 9 years ago

  • Status changed from Patch Pending to Missing Feedback

Missing Feedback.

If someone is still affected by this and could help test a patch to confirm a fix, then please post here. I'm subscribed to updates. Thanks.

Actions

Also available in: Atom