Project

General

Profile

Actions

Feature #2687

closed

[PATCH] Support sendfile on darwin

Added by mackyle over 8 years ago. Updated over 8 years ago.

Status:
Fixed
Priority:
Normal
Category:
core
Target version:
ASK QUESTIONS IN Forums:

Description

The FreeBSD version of sendfile is already supported. Starting
with OS X 10.5, Darwin also supports sendfile, but using a
slightly different argument list.

Add support for darwin's sendfile by introducing a suitable
macro to adjust the arguments.

Patch file attached.

See also http://repo.or.cz/lighttpd/svnmirror/patches.git/commitdiff/45341ce9


Files

Actions #1

Updated by stbuehler over 8 years ago

  • Target version changed from 1.4.x to 1.4.39

Given that it is obviously not the "freebsd-sendfile" I'd prefer having it in a separate file with a separate name like all the others. (Also I don't see any need to patch the sendfile definition with a macro in the header)

Actions #2

Updated by mackyle over 8 years ago

Seems a shame to duplicate all that just for one argument difference, but it's trivial enough to do so here it is.

The new network_darwin_sendfile.c is almost an exact duplicate of network_freebsd_sendfile.c.

See also http://repo.or.cz/lighttpd/svnmirror/patches.git/commitdiff/ae23ffcf

Actions #3

Updated by stbuehler over 8 years ago

  • Assignee deleted (stbuehler)
  • Target version changed from 1.4.39 to 1.4.38
Actions #4

Updated by stbuehler over 8 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r3060.

Actions

Also available in: Atom