Feature #3036
closedThe on/off keywords in boolean configuration options is inconsistent, which might be misleading and error-prone.
Description
In the document of configuration option "extforward.params", users could use "0/1" or "enable/disable" to control the on/off of this function. However, in option "server.http-parseopts", only "enable/disable" could be used. This might be an inconsistence between different configuration options with similar value type. In case of negligence or conventional thinking, it is better to unify the possible values of all boolean options.
Updated by tow-conf about 4 years ago
A similar situation also in option "proxy.forwarded".
Updated by gstrauss about 4 years ago
- Status changed from New to Patch Pending
- Priority changed from Normal to Low
- Target version changed from 1.4.x to 1.4.56
Thanks for pointing that out.
The historical code accepted only "enable" or "disable".
In recent lighttpd versions, I had created some shared code to translate additional string values to boolean while I was writing new code.
I have now gone back through the historical code to more consistently use the shared code for parsing boolean values from user-provided configuration.
Updated by gstrauss about 4 years ago
- Status changed from Patch Pending to Fixed
Applied in changeset 730c932e3c32ea43dbbb2fad51c2ebfc9219b856.
Also available in: Atom