Project

General

Profile

Activity

From 2019-10-11 to 2019-10-17

2019-10-17

04:02 Bug #2986 (Patch Pending): Cookie format specifier is broken
gstrauss
03:58 Bug #2986: Cookie format specifier is broken
... gstrauss

2019-10-16

13:50 Bug #2986: Cookie format specifier is broken
strchrnul() is a GNU extension and is not as portable as C or POSIX standard library calls. gstrauss
09:12 Bug #2986: Cookie format specifier is broken
Patch using @strchrnul@ instead of a @while@ loop. Tested with all discussed edge cases. xoneca
08:37 Bug #2986: Cookie format specifier is broken
I wasn't sure, but it seems empty cookies are allowed by the RFC [1]:... xoneca
08:30 Bug #2986: Cookie format specifier is broken
Sure, fix as you wish.
Your proposed change has a couple edge cases, though: an empty cookie (i.e. two semicolons ...
xoneca
04:50 Bug #2986: Cookie format specifier is broken
This appears to preserve the existing behavior of how whitespace is handled, and also fixes the issue you are seeing:... gstrauss

2019-10-15

12:10 Bug #2986: Cookie format specifier is broken
Thanks. I'll try to review this patch later this week. gstrauss
08:17 Bug #2986: Cookie format specifier is broken
Sorry, I overlooked the removal of the last line in the patch. I've reworked the patch. xoneca

2019-10-11

11:12 Bug #2986: Cookie format specifier is broken
Seems fixed with attached patch. xoneca
11:08 Bug #2986 (Fixed): Cookie format specifier is broken
The @%{name}C@ format specifier doesn't log cookie value correctly.
Example request with header:...
xoneca
 

Also available in: Atom