Project

General

Profile

Bug #1440

Improper ERROR code of expired urls when using mod_secdownload

Added by Anonymous over 8 years ago. Updated over 8 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
mod_secdownload
Target version:
Start date:
Due date:
% Done:

0%

Missing in 1.5.x:

Description

When using mod_secdownload and a valid generated url times out, lighttpd returns error code 408.
This says the client to 'try again later', which is what eg. firefox does, requesting the same expired url 4 times and then giving error to user.

The proper error code here would be 403 as described at http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html .

-- Joe7

Associated revisions

Revision 52840fa1 (diff)
Added by stbuehler over 8 years ago

fix sending "408 - Timeout" instead of "410 - Gone" for timedout urls in mod_secdownload (#1440)

git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@2111 152afb58-edef-0310-8abb-c4023f1b3aa9

History

#1 Updated by over 8 years ago

All you have to do is go into the src folder;

Edit file mod_secure_download.c

find the line 248 and replace
con->http_status = 408;
with
con->http_status = 403; // Changed by TLN 11.18.07

Fixed!

#2 Updated by over 8 years ago

Sorry for the poor formatting, copying and pasting from PuTTy does that:

should be find line 248:

con->http_status = 408;

with

con->http_status = 403; // Changed by TLN 11.18.07

#3 Updated by stbuehler over 8 years ago

  • Status changed from New to Fixed
  • Resolution set to fixed

Fixed in r2111; we send now "410 - Gone".

Also available in: Atom