Bug #1978

mod_expire sends incorrect max-age when using mtime

Added by zezo almost 5 years ago. Updated almost 5 years ago.

Status:FixedStart date:2009-05-10
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:mod_expire
Target version:1.4.23
Missing in 1.5.x:

Description

mod_expire sets Cache-Control: max-age= to the configured interval, and not to the actual stamp.

According to rfc2616, max-age overrides Expires:, and in effect the 'modification' directive turns to 'access'

All tested browsers (IE,Opera,FF,Chrome) comply with the RFC.

Discovered while trying to serve images that change 4 times/day at known moments.

The attached patch shoudt fix this.

max-age.patch Magnifier (953 Bytes) zezo, 2009-05-10 10:11

Associated revisions

Revision 2503
Added by stbuehler almost 5 years ago

Fix max-age value in mod_expire for 'modification' (fixes #1978)

Revision 2504
Added by stbuehler almost 5 years ago

Fix max-age value in mod_expire for 'modification' (fixes #1978)

History

#1 Updated by icy almost 5 years ago

  • Target version changed from 1.4.22 to 1.4.23

While at it, the ints should be changed to time_ts.

target version != affected version

#2 Updated by stbuehler almost 5 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r2503.

#3 Updated by stbuehler almost 5 years ago

  • Estimated time deleted (0.10)

Also available in: Atom