Bug #2233
C99-ism in the code of mod_accesslog
| Status: | Fixed | Start date: | 2010-07-06 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 100% | |
| Category: | mod_accesslog | |||
| Target version: | 1.4.27 | |||
| Missing in 1.5.x: | No |
Description
The mod_accesslog code has a C99-ism in it. The attached patch fixes the code.
patch-src_mod_accesslog_c.diff 
(713 Bytes)
Associated revisions
mod_accesslog: Fix var declarations mixed in source (fixes #2233)
History
#1 Updated by Olaf-van-der-Spek almost 3 years ago
What's wrong with using C99 features?
#2 Updated by brad@comstyle.com almost 3 years ago
Olaf-van-der-Spek wrote:
What's wrong with using C99 features?
It would be nice if the code actually compiled and there is no C99 code anywhere else in the lighttpd codebase and similar issues have been fixed in the past.
#3 Updated by brad@comstyle.com almost 3 years ago
Olaf-van-der-Spek wrote:
What's wrong with using C99 features?
It isn't much of a "feature" to make the code uglier.
Anyway, the same issue was fixed in src/response.c...
http://redmine.lighttpd.net/projects/lighttpd/repository/revisions/2721
#4 Updated by Olaf-van-der-Spek almost 3 years ago
brad@comstyle.com wrote:
It would be nice if the code actually compiled and there is no C99 code anywhere else in the lighttpd codebase and similar issues have been fixed in the past.
It does compile, AFAIK.
Why do C99 features result in ugly code?
#5 Updated by stbuehler almost 3 years ago
- Status changed from New to Fixed
- % Done changed from 0 to 100
Applied in changeset r2743.
Also available in: Atom