Bug #2351
Looks like a bug on mod_status.c
| Status: | Fixed | Start date: | 2011-10-04 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 100% | |
| Category: | - | |||
| Target version: | 1.4.30 | |||
| Missing in 1.5.x: | No |
Description
On mod_status.c line 490:
if (con->request.content_length) {
I think that it should be:
if (c->request.content_length) {
The full code:
for (j = 0; j < srv->conns->used; j++) {
connection *c = srv->conns->ptr[j];
buffer_append_string_len(b, CONST_STR_LEN("<tr><td class=\"string\">"));
buffer_append_string(b, inet_ntop_cache_get_ip(srv, &(c->dst_addr)));
buffer_append_string_len(b, CONST_STR_LEN("</td><td class=\"int\">"));
if (con->request.content_length) {
buffer_append_long(b, c->request_content_queue->bytes_in);
buffer_append_string_len(b, CONST_STR_LEN("/"));
buffer_append_long(b, c->request.content_length);
} else {
buffer_append_string_len(b, CONST_STR_LEN("0/0"));
}
buffer_append_string_len(b, CONST_STR_LEN("</td><td class=\"int\">"));
Associated revisions
Fix mod_status bug: always showed "0/0" in the "Read" column for uploads (fixes #2351)
History
#1 Updated by stbuehler over 1 year ago
good catch. i will commit it soon :)
#2 Updated by stbuehler over 1 year ago
- Description updated (diff)
#3 Updated by stbuehler over 1 year ago
- Status changed from New to Fixed
- % Done changed from 0 to 100
Applied in changeset r2805.
Also available in: Atom