Project

General

Profile

Bug #2761

fd leak with libev in 1.4.42

Added by gstrauss about 1 year ago. Updated about 1 year ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
core
Target version:
Start date:
2016-10-29
Due date:
% Done:

100%

Estimated time:
Missing in 1.5.x:

Description

lighttpd leaks fds if using server.event-handler = "libev" in lighttpd 1.4.42 due to missing cleanup in libev for fds scheduled to be closed.

Associated revisions

Revision eb37615a (diff)
Added by gstrauss about 1 year ago

[core] fix fd leak when using libev (fixes #2761)

server.event-handler = "libev" would leak fds after the change made
in 40f16d5 since fdevent_libev.c:fdevent_libev_poll() always
returned 0 ready events after handling the event callbacks itself.
Therefore, fdevent_libev.c:fdevent_libev_poll() must also call
fdevent_sched_run() to handled fds scheduled to be closed.

This bug was introduced in 1.4.42.

(thx mittwinter for troubleshooting and identifying problem)

Note: server.event-handler = "libev" is no longer recommended.
lighttpd provides event handlers optimized for modern systems for most
platforms, and the limited way that lighttpd uses libev does not provide
any advantages over the OS-specific optimized event handlers.

x-ref:
"fd leak with libev in 1.4.42"
https://redmine.lighttpd.net/issues/2761

History

#1

Updated by gstrauss about 1 year ago

  • Status changed from Patch Pending to Fixed
  • % Done changed from 0 to 100

Also available in: Atom