Project

General

Profile

Bug #2780

mod_webdav crash with keep-alive (1.4.44)

Added by gstrauss 9 months ago. Updated 9 months ago.

Status:
Fixed
Priority:
High
Assignee:
-
Category:
mod_webdav
Target version:
Start date:
2017-01-09
Due date:
% Done:

100%

Estimated time:
Missing in 1.5.x:

Description

mod_webdav crash with keep-alive

mod_webdav allocated its own handler context in lighttpd 1.4.43, and cleaned it up in connection_reset hook, but did not properly reset con->plugin_ctx[p->id] = NULL. lighttpd 1.4.44 moved the plugin cleanup check from the connection_reset hook to connection_close hook, leading to possibility that mod_webdav handler_ctx would be cleaned up multiple times if there were other keep-alive requests (not handled by mod_webdav) on the same socket connection, or simply an HTTP/1.1 without Connection: close.

Associated revisions

Revision 987a76ff (diff)
Added by gstrauss 9 months ago

[mod_webdav] fix crash when plugin_ctx cleaned up (fixes #2780)

fixes error trace
(connections.c.273) missing cleanup in webdav

(thx nickrickard)

x-ref:
"mod_webdav crash with keep-alive (1.4.44)"
https://redmine.lighttpd.net/issues/2780

History

#1 Updated by gstrauss 9 months ago

  • Status changed from Patch Pending to Fixed
  • % Done changed from 0 to 100

Also available in: Atom