Project

General

Profile

Feature #799

mod_fastcgi + X-Sendfile -> mod_staticfile

Added by Anonymous over 11 years ago. Updated over 1 year ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
mod_fastcgi
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Missing in 1.5.x:

Description

hey all,

in mod_fastcgi when used with X-LIGHTTPD-send-file it is now handeled in mod_staticfile (DIRECT).

here is the code:

tags/lighttpd-1.4.11/src/mod_fastcgi.c:2506


/* try to use mode->direct instead of the usual joblist */

fcgi_connection_close(srv, hctx);

/* tell the server to handle this file through mod_staticfile */
buffer_reset(con->uri.path);
buffer_reset(con->physical.path);

buffer_copy_string(con->uri.path, "");
buffer_copy_string_buffer(con->physical.path, ds->value);

con->mode = DIRECT;
joblist_append(srv, con); /* in case we come from the event-handler */

return HANDLER_FINISHED;

-- duke.amix

patch-mod_fastcgi-delegate-x-sendfile (1.88 KB) patch-mod_fastcgi-delegate-x-sendfile patch for 1.4.19 (just added `buffer_free(packet.b)' before return) -- dliakh Anonymous, 2008-08-01 09:08

Related issues

Related to Feature #2017: X-Sendfile handoff to mod-static-file in 1.4.xFixed2009-07-01

Related to Feature #2076: X-sendfile should be able to set content-typeFixed2009-10-02

Associated revisions

Revision b9940f98 (diff)
Added by gstrauss over 1 year ago

[mod_fastcgi] use http_response_xsendfile() (fixes #799, fixes #851, fixes #2017, fixes #2076)

handle X-Sendfile and X-LIGHTTPD-send-file w/ http_response_xsendfile()
if host is configured ( "x-sendfile" = "enable" )

Note: X-Sendfile path is url-decoded for consistency, like X-Sendfile2
(response headers should be url-encoded to avoid tripping over
chars allowed in filesystem but which might change response
header parsing semantics)

Note: deprecated: "allow-x-send-file"; use "x-sendfile"
Note: deprecated: X-LIGHTTPD-send-file header; use X-Sendfile header
Note: deprecated: X-Sendfile2 header; use X-Sendfile header
For now, X-Sendfile2 is still handled internally by mod_fastcgi.

Since http_response_send_file() supports HTTP Range requests,
X-Sendfile2 is effectively obsolete. However, any code, e.g. PHP,
currently using X-Sendfile2 is probably manually generating 206 Partial
Content status and Range response headers. A future version of lighttpd
might remove X-Sendfile2. Existing code should be converted to use
X-Sendfile, which is easily done by removing all the special logic
around using X-Sendfile2, since the 206 Partial Content status and Range
response headers are handled in http_response_send_file().

x-ref:
"mod_fastcgi + X-Sendfile -> mod_staticfile"
https://redmine.lighttpd.net/issues/799
"Feature Request: New option "x-send-file-docroot""
https://redmine.lighttpd.net/issues/851
"X-Sendfile handoff to mod-static-file in 1.4.x"
https://redmine.lighttpd.net/issues/2017
"X-sendfile should be able to set content-type"
https://redmine.lighttpd.net/issues/2076

Revision c380d227
Added by gstrauss over 1 year ago

[mod_cgi,mod_fastcgi,mod_scgi] X-Sendfile features

[core] http_response_send_file() shared code (#2017)
[mod_fastcgi] use http_response_xsendfile()
(fixes #799, fixes #851, fixes #2017, fixes #2076)
[mod_scgi] X-Sendfile feature (fixes #2253)
[mod_cgi] X-Sendfile feature (fixes #2313)

Merge branch 'feature-2017-http_response_send_file' into master

github: closes #59

History

#1

Updated by gstrauss over 1 year ago

  • Related to Feature #2017: X-Sendfile handoff to mod-static-file in 1.4.x added
#2

Updated by gstrauss over 1 year ago

  • Related to Feature #2076: X-sendfile should be able to set content-type added
#3

Updated by gstrauss over 1 year ago

  • Description updated (diff)
  • Status changed from New to Patch Pending
  • Assignee deleted (jan)
  • Target version set to 1.4.40
#4

Updated by gstrauss over 1 year ago

  • Status changed from Patch Pending to Fixed
  • % Done changed from 0 to 100

Also available in: Atom