Project

General

Profile

Actions
Copy link

Bug #1235

closed

NULL arg terminator in execl()/execle() is missing

Added by Anonymous over 17 years ago. Updated over 16 years ago.

Status:
Fixed
Priority:
Normal
Category:
core
Target version:
1.5.0
ASK QUESTIONS IN Forums:

Description

Some systems define NULL as a (void *) pointer, other systems just define it as 0.

On functions having a fixed number of arguments, this is not an issue. Thanks to the prototype, the NULL will be promoted to the right type to close the argument list.

But on functions with a variable number of arguments, if an integer object is used where a pointer is expected, bad things can happen. This is for instance the case on OpenBSD/amd64.

Here's a patch that fixes the execl()/execle() calls in Lighty 1.5 -SVN.

Files

fix-sentinel.patch (2.04 KB) fix-sentinel.patch Fix for NULL-terminated argument lists -- Frank DENIS Anonymous, 2007-06-14 08:45
Actions
Copy link
 #1

Updated by jan over 17 years ago

  • Status changed from New to Fixed
  • Resolution set to fixed

fixed in r1916 for trunk and r1872 for 1.4.x

Actions
Copy link
 #2

Updated by Anonymous over 16 years ago

  • Status changed from Fixed to Need Feedback
  • Resolution deleted (fixed)
Actions
Copy link
 #3

Updated by glen over 16 years ago

  • Status changed from Need Feedback to Fixed
  • Resolution set to fixed
Actions
Copy link

Also available in: Atom