Project

General

Profile

Bug #1485

mod_proxy_core.c: double load decrement

Added by stbuehler almost 12 years ago. Updated about 3 years ago.

Status:
Obsolete
Priority:
Normal
Assignee:
-
Category:
mod_proxy_core
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Missing in 1.5.x:
Yes

Description

As I tried finding out when to decrement load, I found the following
line:

COUNTER_DEC(sess->proxy_backend->load);

in proxy_remove_backend_connection(...) and proxy_recycle_backend_connection(...).

Both only check for sess / sess->proxy_con and then decrement in every
case; but proxy_recycle_backend_connection calls
proxy_remove_backend_connection if it does not keep-alive, so in this
case load gets decremented twice.
Both set sess->proxy to NULL, so it does not happen again.

COUNTER_DEC decrements only if it not 0, so nothing seriously bad
happens.

Proposed change: Execute COUNTER_DEC in recycle only when remove gets not called (see patch).

fix_load_dec.patch (1.21 KB) fix_load_dec.patch mod_proxy_core.c: Fix double load decrement stbuehler, 2007-12-12 20:21

History

#1

Updated by gstrauss about 3 years ago

  • Description updated (diff)
  • Assignee deleted (jan)
  • Missing in 1.5.x set to Yes
#2

Updated by gstrauss about 3 years ago

  • Status changed from New to Obsolete

Also available in: Atom