Project

General

Profile

Actions

Bug #1510

closed

Weird things in chunk.c (functions only handling specific cases, unexpected behaviour)

Added by stbuehler over 16 years ago. Updated over 16 years ago.

Status:
Fixed
Priority:
Normal
Category:
core
Target version:
ASK QUESTIONS IN Forums:

Description

I wrote my own filter, and stumbled across some weird things...
- offset in chunks is used inconsistently (steal_cunks)
- chunkqueue_steal_chunk only worked with MEM_CHUNKs
- chunkqueue_append_mem(chunkqueue *cq, const char * mem, size_t len) copied only len-1 bytes.

The following patch tries to fix this; as the existing code expected the last problem, i had to change other files as well.
While i did this i started to use CONST_STR_LEN in the fixed code, so it should be more readable too.


Files

02-fix_chunks.patch (10.9 KB) 02-fix_chunks.patch stbuehler, 2008-01-10 21:37
Actions #1

Updated by glen over 16 years ago

  • Status changed from New to Fixed
  • Resolution set to fixed

Committed revision r2033.

Actions

Also available in: Atom