Project

General

Profile

Bug #1512

mod_deflate: filesize check is too weak, move to new logstyle

Added by stbuehler over 11 years ago. Updated about 11 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
mod_deflate
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Missing in 1.5.x:

Description

I changed the filesize check to check for the end of the file, not the current offset (abs_offset):


-       if (abs_offset > sce->st.st_size) {
+       if (c->file.length + c->file.start > sce->st.st_size) {

And i replaced the log_error_write calls with ERROR.

1512.patch.gz (4.03 KB) 1512.patch.gz attach to trac glen, 2008-01-18 10:52

History

#1

Updated by stbuehler over 11 years ago

I'd really liked to add an attachment, but i got


Submission rejected as potential spam (IP *.*.*.* blacklisted by sc.surbl.org, SpamBayes determined spam probability of 0.00%, Content contained blacklisted patterns)
#3

Updated by glen over 11 years ago

403 Forbidden - Unknown commit object

#4

Updated by Anonymous over 11 years ago

Yeah, sry. As i keep rebasing to the trunk, history and therefore commit ids are changing.

Current (i will tag them somehow so they won't vanish again):

http://repo.or.cz/w/lighttpd.git?a=commitdiff;h=68a2a5758854492d56d547fb691883bb01d61865

http://repo.or.cz/w/lighttpd.git?a=commitdiff_plain;h=68a2a5758854492d56d547fb691883bb01d61865

#5

Updated by glen over 11 years ago

  • Status changed from New to Assigned

damn. i lost it again :)
i will next time download it before new commits

#6

Updated by Anonymous over 11 years ago

This time the Trac WikiFormatting got me (i didn't pull yet ;-)).

http://repo.or.cz/w/lighttpd.git?a=commitdiff;h=68a2a5758854492d56d547fb691883bb01d61865

http://repo.or.cz/w/lighttpd.git?a=commitdiff_plain;h=68a2a5758854492d56d547fb691883bb01d61865

So next try, with preview and link testing ;-)

(It would be cool to be able to edit ticket comments, i just forget to preview every time^^)

#7

Updated by glen over 11 years ago

  • Status changed from Assigned to Fixed
  • Resolution set to fixed

Committed revision r2055

Also available in: Atom