Project

General

Profile

Actions

Bug #1768

closed

mod_ssi doesn't accept single quotes

Added by Anonymous about 13 years ago. Updated over 5 years ago.

Status:
Fixed
Priority:
Normal
Category:
mod_ssi
Target version:
ASK QUESTIONS IN Forums:

Description

Recently moved a site from Apache to lighttpd. The only problem was the fact that lighttpd refused to interpret our SSI includes, which use single quotes, as so:

<!--#include virtual='/includes/head.txt' -->

A sed script was the solution for now, but I think it should be considered to allow the use of single quotes in SSI.

-- mwild1

Actions #1

Updated by stbuehler about 13 years ago

  • Status changed from New to Fixed
  • Resolution set to wontfix

Here is the regular expression the ssi commands are "parsed" with:


<!--#([a-z]+)\\s+(?:([a-z]+)=\"(.*?)(?<!\\\\)\"\\s*)?(?:([a-z]+)=\"(.*?)(?<!\\\\)\"\\s*)?-->

I don't see how to allow single quotes there... sry. And we will not rewrite mod_ssi for 1.4, ssi isn't worth that imho.

If you have a regex which gives the same result and accepts single quotes just post it :)

Actions #2

Updated by stbuehler about 13 years ago

  • Status changed from Fixed to Wontfix
Actions #3

Updated by marc about 12 years ago

  • Status changed from Wontfix to Reopened
  • Assignee set to stbuehler
  • Target version changed from 1.4.21 to 1.4.24

The following regular expression would match with both "(double) and '(simple) quotes:

<!--#([a-z]+)\\s+(?:([a-z]+)=[\"\'](.*?)(?<!\\\\)[\"\']\\s*)?(?:([a-z]+)=[\"\'](.*?)(?<!\\\\)[\"\']\\s*)?-->
Actions #4

Updated by stbuehler about 12 years ago

  • Status changed from Reopened to Need Feedback
  • Target version changed from 1.4.24 to 1.4.x
  • Missing in 1.5.x set to No

You forget that the start quote must be the same as the end quote, and that you should allow the other quote as content.

Actions #5

Updated by stbuehler almost 12 years ago

  • Status changed from Need Feedback to Wontfix
  • Assignee deleted (stbuehler)
  • Target version deleted (1.4.x)
Actions #6

Updated by gstrauss over 5 years ago

  • Status changed from Wontfix to Patch Pending
  • Target version set to 1.4.40
Actions #7

Updated by gstrauss over 5 years ago

  • Status changed from Patch Pending to Fixed
  • % Done changed from 0 to 100
Actions

Also available in: Atom