Project

General

Profile

Actions
Copy link

Bug #2135

closed

$HTTP["host"] == "hostname:port" works wrong

Added by liming almost 15 years ago. Updated about 12 years ago.

Status:
Fixed
Priority:
Normal
Category:
core
Target version:
1.4.32
ASK QUESTIONS IN Forums:

Description

There is a bug in configure-glue.c, line 289~303

289   if (ck_colon == val_colon) {
290       /* nothing to do with it */
291       break;
292   }

When and only when ck_colon == val_colon == NULL, it breaks. Otherwise, it will go ahead.
Therefore, anything within $HTTP["host"] == "...:port" { } has no chance to be reach.

$HTTP["host"] == "localhost:8880" {
## it would never reach here!
}

Files

configfile-glue.c.patch (794 Bytes) configfile-glue.c.patch liming, 2009-12-31 05:01

Related issues 1 (0 open — 1 closed)

Related to Bug #2439: (connection config) "host:port" should not workInvalid2012-08-24Actions
Actions
Copy link
 #1

Updated by liming almost 15 years ago

  • Status changed from New to Patch Pending
Actions
Copy link
 #2

Updated by stbuehler about 12 years ago

  • Description updated (diff)
  • Target version changed from 1.5.0 to 1.4.32

I will commit fixes soon, feedback whether it is working would be nice. Thx!

Also this affects 1.4.x too (i'll push to 1.5 too)

Actions
Copy link
 #3

Updated by stbuehler about 12 years ago

  • Status changed from Patch Pending to Fixed
  • % Done changed from 0 to 100

Applied in changeset r2853.

Actions
Copy link

Also available in: Atom