Lighttpd

Running on a busy server (single process) with 4000+ connections, 3000+ requests/sec, 200+Mbit/s traffic.
Server load with poll module: 0.7, with event ports: 0.5 (~50% of one core)

From client's perspective connections are handled properly and data is delivered properly.

But when connections are closed, the following appears in the error log:
2010-03-10 11:06:22: (connections.c.1216) connection closed: poll() -> ERR [number]

We can do this in connections.c:

diff -Naur ../lighttpd-1.4.26.orig/src/connections.c ./src/connections.c
--- ../lighttpd-1.4.26.orig/src/connections.c   2010-03-10 11:18:02.173041427 +0100
+++ ./src/connections.c 2010-03-10 11:19:24.161434445 +0100
@@ -1212,7 +1212,7 @@

                        }
                } else if (revents & FDEVENT_ERR) {
-#ifndef USE_LINUX_SIGIO
+#if !defined(USE_LINUX_SIGIO) && !defined(USE_SOLARIS_PORT)
                        log_error_write(srv, __FILE__, __LINE__, "sd",
                                        "connection closed: poll() -> ERR", con->fd);
 #endif

What's the advantage over using libev?

what is the && defined(__sun) needed for?

That is probably remains from the old patch, I don't think it is necessary.

Ok, next question: why call port_getn twice?

stbuehler wrote:

Ok, next question: why call port_getn twice?

Hm, i think i get that now.

But i don't like the handling of ETIME, according to the man page http://compute.cnr.berkeley.edu/cgi-bin/man-cgi?port_getn+3:

     ETIME     The time  interval  expired  before  the  expected
               number  of  events  have  been  posted to the port
               (original value in nget), or nget is updated  with
               the  number of returned port_event_t structures in
               list[].

This doesn't sound like one could rely on nget, or you should at least compare it to the value you provided, and only proceed when they are different.

Hi, to compile, the patch is missing a int declaration:
for (i = 0; i < available_events; ++i) {
solaris_port_events = 0;
should be:
for (i = 0; i < available_events; ++i) {
int solaris_port_events = 0;

Second, it doesn't work (lighttpd doesn't server a single file). The previous patch works.

I can do one or more of these things:
a) help you debug this
b) provide you access to a machine with a working build environment
c) provide you with a virtualbox appliance with a working build environment

Thank you for looking at this,
Martin Matuska

solaris_ports_events = 0; can be removed (the var isn't needed, the flags are read from user_data). wait_for_events should perhaps be initialized to 0.

Apart from that it should work (as long as it compiles).

If it doesn't, well... i guess for all 3 options it would be helpful if you could join #lighttpd@freenode

Whether it works or not, i'm especially interested in compiler warnings :)