Bug #2593
closedPatches in doc for mod_proxy is in-compatible with 1.4.35
Description
I had issues with the mod_proxy and hoped the patches in te documentation might fix it.
However neither of the patches are compatible with 1.4.35
mod_proxy.c - line 468
//- proxy_set_header(con, "X-Forwarded-Proto", con->conf.is_ssl ? "https" : "http");
//+ // proxy_set_header(con, "X-Forwarded-Proto", con->conf.is_ssl ? "https" : "http");
//actual proxy_set_header(con, "X-Forwarded-Proto", con->uri.scheme->ptr);
Updated by gstrauss about 8 years ago
I believe this ticket is referring to the "Enhancements" section at the bottom of https://redmine.lighttpd.net/projects/1/wiki/Docs_ModProxy
Looks like the proposed patches should be reviewed and possibly made to apply to latest lighttpd 1.4.x. However, these should remain optional patches since adding DNS lookup (gethostbyname()) onto that critical path should probably not be default behavior. Same goes for the rewriting of the Host header in the patches.
Updated by stbuehler about 8 years ago
- Category deleted (
documentation) - Status changed from New to Invalid
- Assignee deleted (
omegasteffy)
3rd-party patches are not supported. Integrating DNS-Lookups into the event loop is rather non-trivial and not going to happen in 1.4.x; looking up once and caching forever is wrong too (if you do DNS, do it proper and respect the TTL).
Updated by omegasteffy about 8 years ago
If i understand you replies correctly, the patch'es are not fit for the purpose.
Could you possible comment the documentation page with these patches. Tell they are not recommended (to avoid people like me trying to apply it).
Updated by stbuehler about 8 years ago
If patches in the wiki would be recommended I would have applied them upstream.
Also available in: Atom