Project

General

Profile

Bug #2688

[PATCH] LightyTest.pm: do not shutdown on darwin

Added by mackyle over 3 years ago. Updated about 3 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
test_component
Target version:
Start date:
2015-12-03
Due date:
% Done:

100%

Estimated time:
Missing in 1.5.x:
Yes

Description

While shutting down the sending side of a socket after having
sent the last of the data should not interfere with any future
reception of new data on the same socket, on darwin it does.

If the socket is shutdown for sending, it will fail to receive
any future data from the other end as well unless it already
just happens to be in the receive buffer waiting to be read.

Prevent this problem by skipping the socket shutdown on the
darwin platform which allows the tests to run to normal
completion and pass.

It's unclear whether or not this problem is limited only to
Perl or is system wide.

Patch file attached.

See also http://repo.or.cz/lighttpd/svnmirror/patches.git/commitdiff/97313367


Related issues

Related to Bug #2743: 1.4.40/41 mod_proxy, mod_scgi may trigger POLLHUP on *BSD,DarwinFixed2016-08-02

Actions

Associated revisions

Revision 3058 (diff)
Added by stbuehler over 3 years ago

[tests] do not half-close socket before having received the response (fixes #2688)

From: Stefan Bühler <>

Revision ab05eb7c (diff)
Added by stbuehler over 3 years ago

[tests] do not half-close socket before having received the response (fixes #2688)

From: Stefan Bühler <>

git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@3058 152afb58-edef-0310-8abb-c4023f1b3aa9

History

#1

Updated by stbuehler over 3 years ago

  • Target version changed from 1.4.x to 1.4.38

Hm, I think we probably shouldn't send close on any platform (as that usually is taken as a "I don't need the response anymore" signal by the webserver) before we finished reading the response. I'll try to get this one in for 1.4.38.

#2

Updated by stbuehler over 3 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r3058.

#3

Updated by gstrauss about 3 years ago

  • Related to Bug #2743: 1.4.40/41 mod_proxy, mod_scgi may trigger POLLHUP on *BSD,Darwin added
#4

Updated by gstrauss about 3 years ago

It's unclear whether or not this problem is limited only to Perl or is system wide.

It appears to be a problem on Darwin and likely also *BSDs. See #2743

Also available in: Atom