Project

General

Profile

Actions

Bug #2705

closed

broken module API since 1.4.38

Added by pkubaj almost 6 years ago. Updated about 5 years ago.

Status:
Fixed
Priority:
Normal
Category:
-
Target version:
ASK QUESTIONS IN Forums:

Description

Compiling external modules, e.g. mod_geoip fails with:
mod_geoip.c:148:101: error: too few arguments to function call, expected 4, have 3
if (0 != config_insert_values_global(srv, ((data_config *)srv->config_context->data[i])->value, cv)) {

This happens on FreeBSD 10.2-RELEASE with Clang 3.4.1. I can write a patch myself, but I need to know what I should put in config_insert_values_global, so that running it doesn't change anything.

Actions #1

Updated by stbuehler almost 6 years ago

  • Status changed from New to Invalid

How about searching for how all the other modules are calling it? And maybe also have a look at the commit changing it?

Actions #2

Updated by gstrauss over 5 years ago

I uploaded a patch to https://redmine.lighttpd.net/projects/lighttpd/wiki/Docs_ModGeoip which applies to mod_geoip_for_1.4.c (rename to mod_geoip.c) in order to compile mod_geoip.c cleanly under lighttpd 1.4.39. (I have not tested beyond compiling it.)

Actions #3

Updated by gstrauss about 5 years ago

  • Target version set to 1.4.42
Actions #4

Updated by gstrauss about 5 years ago

  • Status changed from Invalid to Fixed
Actions

Also available in: Atom