Feature #2706: Matching IPv6 addresses with $HTTP["remoteip"] - Lighttpd - lighty labs

Actions

Copy link

Feature #2706

closed

Matching IPv6 addresses with $HTTP["remoteip"]

Added by ef over 8 years ago. Updated almost 8 years ago.

Status:

Fixed

Priority:

Normal

Category:

core

Target version:

1.4.40

ASK QUESTIONS IN Forums:

Description

$HTTP["remoteip"] doesn't match on IPv6 addresses.
It may also be useful for it to match v6-mapped IPv4 addresses.
I supplied a patch to do both in #385, but was asked to open a new bug.
I understand that the preferred configuration is to use bindv6only, but some installments (not mine) may be stuck with v6-mapped addresses so silently matching them with dotted-quad addresses may come handy to those people.
The attached patch lacks MS-Windows support.

Files

remoteip-v6 (3.66 KB) remoteip-v6

patch fo allow $HTTP[remoteip] compares to v6 and v6-mapped v4 addresses

ef, 2016-01-19 15:32

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by gstrauss about 8 years ago

Read through patch and it looks sane to me.

@ef, would you consider writing a few tests in tests/*.t to validate the patch? Thanks.

Actions

Copy link

Updated by stbuehler about 8 years ago

Target version set to 1.4.x

Actions

Copy link

Updated by stbuehler about 8 years ago

Related to Bug #385: Enabling ipv6 makes matching subnets with $HTTP["remoteip"] inoperable. added

Actions

Copy link

Updated by gstrauss about 8 years ago

@ef: would you consider writing a few tests in tests/*.t to validate the patch? Thanks.

Actions

Copy link

Updated by ef about 8 years ago

gstrauss wrote:

would you consider writing a few tests in tests/*.t to validate the patch?

I may consider that, but I'm neither familiar with lighttpd's test framework nor will I have time left to do that anytime soon, sorry.

Actions

Copy link

Updated by gstrauss about 8 years ago

Tracker changed from Bug to Feature

The attached patch lacks MS-Windows support.

Would you provide a link or two, or a quick explanation why? Thx.

Actions

Copy link

Updated by ef about 8 years ago

gstrauss wrote:

Would you provide a link or two

I don't understand. A link to what?

or a quick explanation why?

Because I don't know how to write that support.
There's an #ifdef __WIN32 in the code and the true branch uses some inet_addr() function (while the false branch used inet_aton() and now uses inet_pton()).
I have no idea how to parse (nor any chance to test) network addresses on MS-Windows.

Actions

Copy link

Updated by gstrauss about 8 years ago

Windows provides inet_pton() in versions of Windows after Windows XP, so that patch needs to be adjusted for that. I don't think we should worry about supporting Windows XP or earlier.

Actions

Copy link