Project

General

Profile

Feature #2836

Remove check for broken sendfile implementations

Added by stbuehler almost 3 years ago. Updated almost 3 years ago.

Status:
Fixed
Priority:
Normal
Category:
build_autotools
Target version:
ASK QUESTIONS IN Forums:

Description

Since svn|r1 autobuild (back then source:svn|configure.in@1#L301, now configure.ac) checks for broken sendfile implementations (HAVE_SENDFILE_BROKEN), and assumes sendfile is always broken when cross compiling.

Imho it's probably safe to drop the check completely, but we could at least assume working sendfile when cross compiling. Users can manually select a server.network-backend in the config anyway.

#1

Updated by gstrauss almost 3 years ago

Makes sense. If sendfile() fails due to not being implemented, we fall back to other mechanisms (writev() or write()).

However, if sendfile is present but broken, then server.network-backend must be explicitly specified in config file to something else, since sendfile is the default if available and server.network-backend is not specified.

#2

Updated by gstrauss almost 3 years ago

  • Status changed from New to Patch Pending
  • Target version changed from 1.4.x to 1.4.48
#3

Updated by stbuehler almost 3 years ago

  • Description updated (diff)
#4

Updated by gstrauss almost 3 years ago

  • Status changed from Patch Pending to Fixed
  • % Done changed from 0 to 100

Also available in: Atom