Feature #2836: Remove check for broken sendfile implementations - Lighttpd - lighty labs

Actions

Copy link

Feature #2836

closed

Remove check for broken sendfile implementations

Added by stbuehler about 7 years ago. Updated about 7 years ago.

Status:

Fixed

Priority:

Normal

Category:

build_autotools

Target version:

1.4.48

ASK QUESTIONS IN Forums:

Description

Since svn|r1 autobuild (back then source:svn|configure.in@1#L301, now configure.ac) checks for broken sendfile implementations (HAVE_SENDFILE_BROKEN), and assumes sendfile is always broken when cross compiling.

Imho it's probably safe to drop the check completely, but we could at least assume working sendfile when cross compiling. Users can manually select a server.network-backend in the config anyway.

Actions

Copy link

Updated by gstrauss about 7 years ago

Makes sense. If sendfile() fails due to not being implemented, we fall back to other mechanisms (writev() or write()).

However, if sendfile is present but broken, then server.network-backend must be explicitly specified in config file to something else, since sendfile is the default if available and server.network-backend is not specified.

Actions

Copy link