Feature #3071
closedFreeBSD build update
Description
- build fix with SOL_TCP constant definition.
- build update to support cpu affinity.
Files
Updated by stbuehler over 3 years ago
Hi.
A few generic notes:- please upload patches with proper filenames (.patch extension helps the mime detection)
- please split patches into logical changes; e.g. don't merge SOL_TCP and cpu affinity
I refactored the affinity handling a bit, then added the FreeBSD handling on top. Also instead of #define SOL_TCP
I just switched to IPPROTO_TCP
.
I'm also quite sure the affinity handling shouldn't go for the process, but just for the thread, and you didn't enabled FreeBSD in core_workers_cpu_affinity
.
I pushed my changes to https://git.lighttpd.net/lighttpd/lighttpd2/src/branch/personal/stbuehler/freebsd-3071 - you can take a look in a shallow clone like this (or any other way you prefer):
git clone --depth 4 -b personal/stbuehler/freebsd-3071 https://git.lighttpd.net/lighttpd/lighttpd2
I might just merge them some day, but a positive feedback would help.
Updated by devnexen over 3 years ago
Tested the build, in the file include/lighttpd/utils.h, line 10, it would be better to put the HEDLEY_NO_RETURN specifier in the beginning of the declaration instead other than that it works.
Updated by stbuehler over 3 years ago
- Status changed from New to Fixed
Thanks for reporting and the feedback. Should be merged now.
Also available in: Atom